All checks have passed 🎉 @TomasVotruba it is ready for review.

my intial motivation for this change was performance.

did you check whether this new implementation is faster then the previous one?

Not yet check on a large diff. The check may need a large diff on a single run to see comparison, yes?

IIRC the reproducer is described in rectorphp/rector#7899

I tried that, seems 1 second faster:

Before

bin/rector --clear-cache --dry-run  8.33s user 0.09s system 99% cpu 8.441 total

After

bin/rector --clear-cache --dry-run  6.86s user 0.10s system 98% cpu 7.064 total

Updated stop loop on found --- Original and +++ New, got new result:

Before

bin/rector --clear-cache --dry-run  8.33s user 0.09s system 99% cpu 8.441 total

After

bin/rector --clear-cache --dry-run  6.93s user 0.09s system 99% cpu 7.033 total

@samsonasik What are numbers on one if our private client's project? Real projects are better than Rector itself

@TomasVotruba yes, the measure is depends on how many files changed, more diffs, more faster.

I tried in our project with 70 files changed, that means there are diffs, it 3 seconds faster.

Before

../rector-src/bin/rector process src --dry-run --clear-cache  796.63s user 21.67s system 652% cpu 2:05.41 total

After

../rector-src/bin/rector process src --dry-run --clear-cache  772.05s user 20.86s system 647% cpu 2:02.38 total

@TomasVotruba I've updated with reduce loop, remove array_map, and it seems faster 7 seconds now, applied 70 files changes, tested on our project:

Before 2:05.41

../rector-src/bin/rector process src --dry-run --clear-cache  796.63s user 21.67s system 652% cpu 2:05.41 total

After 1:58.40

../rector-src/bin/rector process src --dry-run --clear-cache  752.03s user 19.20s system 651% cpu 1:58.40 total

Let's give it a try 👍

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.